fix: add missing @types/minimatch devDependency#9928
Open
k1832 wants to merge 1 commit intoVSCodeVim:masterfrom
Open
fix: add missing @types/minimatch devDependency#9928k1832 wants to merge 1 commit intoVSCodeVim:masterfrom
k1832 wants to merge 1 commit intoVSCodeVim:masterfrom
Conversation
`gulp prepare-test` fails when re-resolving dependencies (e.g. `yarn install --no-lockfile`) because `@types/glob` depends on `@types/minimatch` types, but `@types/minimatch` was not in devDependencies. CI uses `yarn install --frozen-lockfile` which pins the original minimatch version that bundled its own types, so CI passes. The issue only surfaces on a fresh contributor setup where yarn resolves a newer minimatch that no longer bundles types.
2 tasks
k1832
changed the title
mao19901987-lang
approved these changes
Feb 10, 2026
mao19901987-lang
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
@types/minimatch@5.1.2to devDependencies.gulp prepare-testfails when re-resolving dependencies (e.g.yarn install --no-lockfile) because@types/globdepends on@types/minimatchtypes, but it was not listed as a devDependency.CI uses
yarn install --frozen-lockfilewhich pins the original minimatch that bundled its own types, so CI passes. The issue surfaces on a fresh contributor setup where yarn resolves a newer minimatch that no longer bundles types.Which issue(s) this PR fixes
Fixes #9930
Special notes for your reviewer:
npx gulp prepare-testcompletes without errors