upipe_pcap_src: new pipe to read pcap files#1096
Conversation
|
Could you rebase and solve conflicts with the build system so we can merge? |
nto
left a comment
nto
left a comment
There was a problem hiding this comment.
A wrapper for an external library should be a standalone module, not included in upipe-modules.
|
Please check examples/Build.mk pcap-deps pcap-deps = upipe_pcap_src doesn't work as I thought it would |
nto
left a comment
nto
left a comment
There was a problem hiding this comment.
Commit message should be in imperative style.
There was a problem hiding this comment.
This does not seem to do anything useful? Shouln't it use a udpsink to send the packets instead of dropping them?
There was a problem hiding this comment.
I guess it could do something, don't remember how I tested it exactly.
I can remove this dummy exemple if needed.
funman
force-pushed
the
pcap
branch
3 times, most recently
from
d5c1740 to
1f1fbcb
Compare
|
pcap depends on bitstream. I suppose right now it will build an empty .so if bitstream is not present |
Such dependency is handled automatically. If |
quarium
left a comment
quarium
left a comment
There was a problem hiding this comment.
Could you had the missing documentation and a test?
Gonna look at test and mkdoc |
|
I'm gonna rebase at some point before merging |
funman
force-pushed
the
pcap
branch
2 times, most recently
from
ac24d0f to
745a870
Compare
|
Need to complexify a bit the test also |
|
Test segfaults on ubuntu arm for some reason, valgrind is clean on x64 |
5 participants
Source using pcap files