Use correct itemInUse method (Fixes #423)#424
Open
Phoenix616 wants to merge 1 commit intoUpdated-NoCheatPlus:masterfrom
Open
Use correct itemInUse method (Fixes #423)#424Phoenix616 wants to merge 1 commit intoUpdated-NoCheatPlus:masterfrom
Phoenix616 wants to merge 1 commit intoUpdated-NoCheatPlus:masterfrom
Conversation
Also adjust documentation so the correct BridgeMisc method is used and prevent potential NPE in BridgeMisc#getItemInUse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes that the right click (charge) functionality of spears leads to false positives and that charging is impossible with the default config. (See #423)
I also adjusted the documentation so the correct BridgeMisc method is mentioned and hopefully such errors are prevented and also adjusted the BridgeMisc code slightly to prevent potential NPE in BridgeMisc#getItemInUse