Skip to content

Conversation

@radu-mocanu
Copy link
Contributor

  • add circular deps flags to runtime schema

@radu-mocanu radu-mocanu self-assigned this Jan 12, 2026
Copilot AI review requested due to automatic review settings January 12, 2026 19:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two internal boolean fields to track circular dependencies in the runtime schema and bumps the package version to 0.4.1.

Changes:

  • Added has_input_circular_dependency and has_output_circular_dependency fields to UiPathRuntimeSchema
  • Version bump from 0.4.0 to 0.4.1 in pyproject.toml and uv.lock

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/uipath/runtime/schema.py Added two boolean fields with exclude=True to track circular dependencies without serializing them
pyproject.toml Updated package version to 0.4.1
uv.lock Updated locked version to 0.4.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +60 to +61
has_input_circular_dependency: bool = Field(default=False, exclude=True)
has_output_circular_dependency: bool = Field(default=False, exclude=True)
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new circular dependency fields lack description parameters, which is inconsistent with other fields in this class. Consider adding descriptions to explain their purpose, similar to how other fields like 'graph' and 'metadata' include descriptions.

Suggested change
has_input_circular_dependency: bool = Field(default=False, exclude=True)
has_output_circular_dependency: bool = Field(default=False, exclude=True)
has_input_circular_dependency: bool = Field(
default=False,
exclude=True,
description="Indicates whether the input definition contains circular dependencies",
)
has_output_circular_dependency: bool = Field(
default=False,
exclude=True,
description="Indicates whether the output definition contains circular dependencies",
)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant