Fix volume misplaced #2287
Closed
Fix volume misplaced #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a volume ordering bug where volume operations were going to the wrong volumes due to incorrect sorting. The fix changes the ORDER BY clause in volume queries from sorting by id to sorting by n_order, which is the proper semantic ordering field used throughout the codebase.
Changes:
- Fixed volume ordering in
Ravada::Front::Domain->list_volumes()to usen_orderinstead ofid - Added comprehensive test
test_order()to verify volumes are returned in correct order even when IDs are non-sequential
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/Ravada/Front/Domain.pm | Fixed ORDER BY clause in list_volumes query to use n_order instead of id |
| t/vm/40_volumes.t | Added test_order() function and _swap_volumes_id() helper to verify fix by manipulating volume IDs and checking correct ordering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+771
to
+772
| $sth->execute($domain->id); | ||
|
|
There was a problem hiding this comment.
This statement re-executes the query but doesn't fetch or use the results. This line appears to be dead code and can be removed.
Suggested change
| $sth->execute($domain->id); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some volume operations go to wrong item. Sort it properly.