fix: CSS variables scoping to depend VersionInfo#13091
Open
fix: CSS variables scoping to depend VersionInfo#13091
Conversation
Collaborator
|
🚀 Deployed on https://pr-13091--ui5-webcomponents-preview.netlify.app |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #12984, all CSS variables from the
main,fiori,ai, andcompactpackages are now defined on the custom element instead of the document. As of version 2.19, CSS variable scoping is no longer needed for these packages.To support third-party packages that still rely on scoping (until they migrate their variables), a new parameter has been introduced to optionally append the version to the variable name. Additionally, the
getScopedVarNamefunction has been marked as deprecated.Build-time variable scoping has also been reworked. All variables are now scoped to the version of the base package, since it serves as the entry point of each runtime. This ensures that scoping is aligned with the version specified in the
VersionInfoobject.Fixes: #13014
Fixes: #13062