Skip to content

feat(ui5-date-picker, ui5-daterange-picket, ui5-datetime-picker): introduce show-clear-icon property #13055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GDamyanov wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(ui5-date-picker, ui5-daterange-picket, ui5-datetime-picker): introduce show-clear-icon property #13055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c95d1a2
feat: introduce show-clear-icon property
GDamyanov Feb 10, 2026
7b06057
Merge branch 'main' into datepickes-clear-icon
GDamyanov Feb 10, 2026
2d3348a
refactor: clear code
GDamyanov Feb 10, 2026
c45212a
refactor: remove the logic for clear icon click
GDamyanov Feb 16, 2026
37c7c03
Merge branch 'main' into datepickes-clear-icon
GDamyanov Feb 17, 2026
af4bd40
Merge branch 'main' into datepickes-clear-icon
GDamyanov Feb 17, 2026
0e3116d
Merge branch 'main' into datepickes-clear-icon
GDamyanov Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions packages/main/cypress/specs/DatePicker.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,36 @@ describe("Date Picker Tests", () => {
.should("have.attr", "placeholder", "test placeholder");
});

it("clear icon", () => {
cy.mount(<DatePicker showClearIcon={true} value="Jan 1, 2020" formatPattern="MMM d, y"></DatePicker>);

cy.get("[ui5-date-picker]")
.as("datePicker");

cy.get<DatePicker>("@datePicker")
.shadow()
.find("ui5-datetime-input")
.shadow()
.find(".ui5-input-clear-icon")
.should("exist");

cy.get<DatePicker>("@datePicker")
.shadow()
.find("ui5-datetime-input")
.shadow()
.find(".ui5-input-clear-icon-wrapper")
.click();

cy.get<DatePicker>("@datePicker")
.shadow()
.find("ui5-datetime-input")
.shadow()
.find(".ui5-input-clear-icon")
.should("not.exist");

cy.get<DatePicker>("@datePicker")
.should("have.value", "");
});

it("Selected date from daypicker is the same as datepicker date", () => {
cy.mount(<DatePicker value="Jan 29, 2019" formatPattern="MMM d, y"></DatePicker>);
Expand Down
18 changes: 18 additions & 0 deletions packages/main/src/DatePicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,15 @@ class DatePicker extends DateComponentBase implements IFormInputElement {
@property()
accessibleDescriptionRef?: string;

/**
* Defines whether the clear icon of the input will be shown.
* @default false
* @public
* @since 2.20.0
*/
@property({ type: Boolean })
showClearIcon = false;

@property({ type: Object })
_respPopoverConfig?: object;

Expand Down Expand Up @@ -660,6 +669,15 @@ class DatePicker extends DateComponentBase implements IFormInputElement {
this._updateValueAndFireEvents((e.target as DatePicker).value, false, ["input"], false);
}

_handleClearIconClick() {
this.value = "";
this._dateTimeInput.value = "";
this._updateValueState();
this._dateTimeInput.focus();
this.fireDecoratorEvent("change", { value: this.value, valid: true });
this.fireDecoratorEvent("value-changed", { value: this.value, valid: true });
}

/**
* Checks if the provided value is valid and within valid range.
* @protected
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/DatePickerInputTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export default function DatePickerInputTemplate(this: DatePicker) {
onInput={this._onInputInput}
Copy link
Contributor

@nnaydenow nnaydenow Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we discuss this with team Rila in order to add custom event (e.g _clearIconClick) which to reuse here instead of checking inputType and etc?

Copy link
Contributor Author

@GDamyanov GDamyanov Feb 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's wait for the discussion

Copy link
Contributor Author

@GDamyanov GDamyanov Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional logic was removed since we will update the value on onChange.

onui5-_request-submit={this._onInputRequestSubmit}
onKeyDown={this._onkeydown}
showClearIcon={this.showClearIcon}
>

{!this.open && this.valueStateMessage.length > 0 &&
Expand Down
5 changes: 5 additions & 0 deletions packages/main/src/themes/DatePicker.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,9 @@

.ui5-date-picker-popover::part(header) {
padding: 0;
}

:host([show-clear-icon]) .ui5-date-picker-input:not([value]),
:host([show-clear-icon]) .ui5-date-picker-input[value=""] {
width: calc(100% + 36px);
}
6 changes: 6 additions & 0 deletions packages/main/src/themes/DateRangePicker.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,10 @@
min-width:inherit;
color: inherit;
background-color: inherit;
}

:host([show-clear-icon]) .ui5-date-picker-input:not([value]),
:host([show-clear-icon]) .ui5-date-picker-input[value=""] {
width: 100%;
min-width:inherit;
}
6 changes: 6 additions & 0 deletions packages/main/src/themes/DateTimePicker.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,10 @@
min-width: inherit;
color: inherit;
background-color: inherit;
}

:host([show-clear-icon]) .ui5-date-picker-input:not([value]),
:host([show-clear-icon]) .ui5-date-picker-input[value=""] {
width: 100%;
min-width:inherit;
}
Loading
Loading