Nested file support #226
Nested file support #226
Conversation
Recursively searches nested folders for audio files to process. Extension and files to skip can be specified.
This comment was marked as outdated.
This comment was marked as outdated.
also cast ignored list to set to reduce time complexity
feat: allowed for entire directories to be ignored
Changed isolate() to take the filepath and split it to keep the FOLDER column consistent.
| root_dir = os.path.abspath(root_dir) | ||
| root_dir = Path(root_dir) | ||
| # get all files | ||
| audio_files = root_dir.rglob(f"*{extension}") |
There was a problem hiding this comment.
Is this intended to be case sensitive or case insensitive?
There was a problem hiding this comment.
File names/directories and extensions are all intentionally case-sensitive right now. Any reason this shouldn't be the case?
There was a problem hiding this comment.
Keep in mind that Unix filesystems are case-sensitive, while Windows filesystems are case-insensitive. Thus, you may have unintended behavior on Windows vs Unix.
There was a problem hiding this comment.
I see, what suggestions do you have?
There was a problem hiding this comment.
I don't see a reason for this to be case-sensitive. .wav and .WAV extensions mean the same, even under Unix.
There was a problem hiding this comment.
Makes sense. I think the given root dir should be kept case-sensitive, though?
There was a problem hiding this comment.
Depends on how much of a mess you want Unix behavior to be
No description provided.