added Simple Top course Filter App#17
Open
saurabhm02 wants to merge 3 commits intoTrinity-Developers-Club:mainfrom
Open
added Simple Top course Filter App#17saurabhm02 wants to merge 3 commits intoTrinity-Developers-Club:mainfrom
saurabhm02 wants to merge 3 commits intoTrinity-Developers-Club:mainfrom
Conversation
MridulTi
requested changes
Oct 14, 2023
Member
MridulTi
left a comment
MridulTi
left a comment
There was a problem hiding this comment.
please make sure that you do not add node modules for that you need to have .gitignore file it your pushed folder where '/node_modules/ is mentioned. If you are unable to figure that out make sure to ask maintainers
Contributor
Author
|
can u check it now is it resolved or not . i m just forget to add gitignore file |
Member
|
@saurabhm02 nope its not resolved, you should try doing it with a new branch and new pull request, it might work then, thing is your gitignore file is outside the folder where your nodemodule is so it basically is not working at all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i added a simple React App which is based on Filter (Top courses filter app"