Change setting method of periodic execution to cronjob style#49
Change setting method of periodic execution to cronjob style#49futabooo wants to merge 3 commits intoTradeMe:masterfrom
Conversation
|
Thanks for the contribution! I think if we were to accept this change the usage of |
|
Thank you for your comment! |
|
@josh-burton I tried to leave the option of interval. |
appstorereviews.js
Outdated
| if (config.regions === false) { | ||
| try { | ||
| config.regions = JSON.parse(fs.readFileSync(__dirname + '/regions.json')); | ||
| config.regions = JSON.parse(fs.readFileSync(__dirname + '/regions.json')); |
There was a problem hiding this comment.
Maybe leaving the styling thing along will be better when implementing some functions? Otherwise the diff will including so many changes not related to the topic, make the review and code tracing a little bit harder.
It will be very great if the styling will be fixed with CI testing in another PR 👍
There was a problem hiding this comment.
I think so too. This PR undo unnecessary diffs 🙇
futabooo
force-pushed
the
cron-style-schedule
branch
from
f3cb690 to
c56c481
Compare
3 participants
title is everything