Skip to content

Conversation

@HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented May 7, 2025

Which issue(s) this PR fixes:

https://github.com/ThinBridge/Chronos-SG/issues/305

What this PR does / why we need it:

Some sites, especially web meeting sites, do not work correctly because of the OnProtocolExecution implementation.

  • Zoom does not work without browser->StopLoad() when allow_os_execution is false.
    • If allow_os_execution is true, browser->StopLoad() is not needed.
  • Webex does not work if browser->StopLoad() is executed.

To be able to work those site correctly, this patch introduces AllowedProtocols to the config file and improve the OnProtocolExecution implementation.
If a protocol is allowed to execute on OS, do not execute browser->StopLoad().
If a protocol is not allowed to execute on OS, execute browser->StopLoad().

Here is the AllowedProtocols usage:

AllowedProtocols=|zoommtg:|webex:|

How to verify the fixed issue:

How to verify the fixed issue:

  • Open ChronosDefault.conf or Chronos.conf
  • Add AllowedProtocols=|ms-teams:|zoommtg:|webex:| to the config file.
  • Save the config file
  • Start Chronos
  • Open the Zoom meeting room.
    • Confirm that a popup to confirm executing the Zoom native app is displayed.
      • image
  • Click the "Join" button
    • Confirm that Chronos does not crash
    • Confirm that the meeting room is displayed
  • Open the Microsoft Teams meeting room
    • Confirm that a popup to confirm executing the Microsoft Teams native app is displayed.
      • image
  • Click the "Continue to the browser" button
    • Confirm that Chronos does not crash
    • Confirm that the meeting room is displayed
  • Open the Webex meeting room
    • You can create and join a meeting room by logining to the Webex site
      You need to register to the Webex beforehand
    • Confirm that a popup to confirm executing the Microsoft Teams native app is displayed.
      • image
  • Click the "Join from this browser" button
    • Confirm that Chronos does not crash
    • Confirm that the meeting room is displayed
  • Close Chronos
  • Open ChronosDefault.conf or Chronos.conf
  • Change AllowedProtocols to AllowedProtocols=
  • Save the config file
  • Start Chronos
  • Open the Zoom meeting room.
    • Confirm that a popup to confirm executing the Zoom native app is not displayed.
  • Click the "Join" button
    • Confirm that Chronos does not crash
    • Confirm that the meeting room is displayed
  • Open the Microsoft Teams meeting room
    • Confirm that a popup to confirm executing the Microsoft Teams native app is not displayed.
  • Click the "Continue to the browser" button
    • Confirm that Chronos does not crash
    • Confirm that the meeting room is displayed
  • Open the Webex meeting room
    • You can create and join a meeting room by logining to the Webex site
      You need to register to the Webex beforehand
    • Confirm that a popup to confirm executing the Microsoft Teams native app is not displayed.
  • Click the "Join from this browser" button
    • Confirm that Chronos does not crash
    • Confirm that the meeting room is not loaded
      • Note: This is feel like a bug but a Webex site specification.
  • Close Chronos
  • Open ChronosDefault.conf or Chronos.conf
  • Change AllowedProtocols to AllowedProtocols=*
  • Save the config file
  • Open the Zoom meeting room.
    • Confirm that a popup to confirm executing the Zoom native app is displayed.
      • image
  • Click the "Join" button
    • Confirm that Chronos does not crash
    • Confirm that the meeting room is displayed
  • Open the Microsoft Teams meeting room
    • Confirm that a popup to confirm executing the Microsoft Teams native app is displayed.
      • image
  • Click the "Continue to the browser" button
    • Confirm that Chronos does not crash
    • Confirm that the meeting room is displayed
  • Open the Webex meeting room
    • You can create and join a meeting room by logining to the Webex site
      You need to register to the Webex beforehand
    • Confirm that a popup to confirm executing the Microsoft Teams native app is displayed.
      • image
  • Click the "Join from this browser" button
    • Confirm that Chronos does not crash
    • Confirm that the meeting room is displayed
  • Close Chronos

@HashidaTKS HashidaTKS marked this pull request as draft May 7, 2025 01:30
Usage:

```
AllowedProtocols=|zoommtg:|webex:|
```

We can use `*` to allow all

```
AllowedProtocols=*
```
@HashidaTKS HashidaTKS force-pushed the specify-allow-os-execution-list branch from 5414936 to c031c85 Compare May 15, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants