Draft: add a config param to specify protocols allowed os execution #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
https://github.com/ThinBridge/Chronos-SG/issues/305
What this PR does / why we need it:
Some sites, especially web meeting sites, do not work correctly because of the
OnProtocolExecutionimplementation.browser->StopLoad()whenallow_os_executionisfalse.allow_os_executionistrue,browser->StopLoad()is not needed.browser->StopLoad()is executed.To be able to work those site correctly, this patch introduces
AllowedProtocolsto the config file and improve theOnProtocolExecutionimplementation.If a protocol is allowed to execute on OS, do not execute
browser->StopLoad().If a protocol is not allowed to execute on OS, execute
browser->StopLoad().Here is the
AllowedProtocolsusage:How to verify the fixed issue:
How to verify the fixed issue:
AllowedProtocols=|ms-teams:|zoommtg:|webex:|to the config file.You need to register to the Webex beforehand
AllowedProtocolstoAllowedProtocols=You need to register to the Webex beforehand
AllowedProtocolstoAllowedProtocols=*You need to register to the Webex beforehand