Added C++ Example with ported CheesyVisionServer#1
Added C++ Example with ported CheesyVisionServer#1DjScribbles wants to merge 2 commits intoTeam254:masterfrom
Conversation
|
I know Wait() takes a double value of seconds, and in my experience (which is not in vxWorks) Sleep() takes an integer number of milliseconds, however it is ambiguous as near as I can tell, and could explain the odd behavior I've seen. It may be clearer to change it to Wait(.05); |
|
I found the docs. sleep is in seconds. On Thu, Apr 17, 2014 at 4:37 PM, DjScribbles notifications@github.comwrote:
|
|
Ok, well excellent catch, would you like me to update and submit a new request, or would you like to resolve it on your end? |
|
Just add another commit that fixes it. If you push to this branch it should
|
Sleep is in seconds, not milliseconds. To keep same resolution, switched to Wait(double seconds).
|
Ok, done. |
There was a problem hiding this comment.
Your indentation is inconsistent...
Please explicitly make private members private.
class {
public:
...
private:
...
};
|
Thanks for the pull request! We have a high quality bar (as you would expect), hence the large number of comments. Hopefully we can whip everything into shape quickly. |
|
I don't want to sound rude, because I don't disagree with any of your feedback, but I don't really have the energy this week to follow through with them; we've had 3 weeks straight of back to back competitions; our season is now over, and I'm trying to get back to the rest of life for a while. You are welcome to make any changes you wish, I'll make some quick comments above, but beyond that, it may be too late before I have the time and energy to go through everything you've suggested. |
As noted on Chief Delphi, I did encounter some problems on our second day of using the ported CheesyVisionServer code, however other teams have used it successfully without any trouble (as did we our first day).