-
Notifications
You must be signed in to change notification settings - Fork 1
feat: domain model 테스트 코드 작성 #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/1.6.0
Are you sure you want to change the base?
Conversation
- Mockk, Coroutines Test 라이브러리 의존성을 추가 - 테스트 시 Android 프레임워크에 의존적인 코드에 대해 기본 값을 반환하도록 `testOptions`를 설정
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| import org.junit.Test | ||
|
|
||
| class GetSearchedNovelsUseCaseTest { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line
| private val dummyExploreResultEntity = ExploreResultEntity( | ||
| resultCount = 0L, | ||
| isLoadable = true, | ||
| novels = emptyList() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"
| } | ||
|
|
||
| @Test | ||
| fun `처음 검색하면 페이지는 0, 사이즈는 20으로 레포지토리에 요청한다`() = runTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before expression body
|
|
||
| @Test | ||
| fun `처음 검색하면 페이지는 0, 사이즈는 20으로 레포지토리에 요청한다`() = runTest { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:no-empty-first-line-in-method-block reported by reviewdog 🐶
First line in a method block should not be empty
| novelRepository.fetchNormalExploreResult( | ||
| searchWord = "웹소설", | ||
| page = 0, | ||
| size = 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"
|
|
||
| @Test | ||
| fun `같은 평점을 다시 설정하면 기본 상태로 돌아간다`() { | ||
| val rating = NovelRating.from(3.0f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Expected newline before '.'
| import org.junit.Test | ||
|
|
||
| class RatingTest { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line
| package com.into.websoso.domain.library.model | ||
|
|
||
| import com.into.websoso.domain.library.model.ReadStatuses.Companion.toReadStatuses | ||
| import org.junit.Assert.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:no-wildcard-imports reported by reviewdog 🐶
Wildcard import
| import org.junit.Test | ||
|
|
||
| class ReadStatusesTest { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line
| import org.junit.Test | ||
|
|
||
| class SortCriteriaTest { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴