fix: Contextual logging import to use absolute path#92
Open
morgan-wowk wants to merge 1 commit intomasterfrom
Open
fix: Contextual logging import to use absolute path#92morgan-wowk wants to merge 1 commit intomasterfrom
morgan-wowk wants to merge 1 commit intomasterfrom
Conversation
Changed the import in structured_logging.py from relative to absolute to ensure that the same contextual_logging module instance is used across all imports. This fixes an issue where context metadata set in one module was not visible in another due to separate module instances having separate ContextVar objects. This ensures LoggingContextFilter and contextual_logging.logging_context share the same _context_metadata ContextVar, allowing contextual data like container_execution_id and execution_node_ids to appear in logs. Co-authored-by: Cursor <cursoragent@cursor.com>
morgan-wowk
commented
Feb 13, 2026
| import logging | ||
|
|
||
| from . import contextual_logging | ||
| from cloud_pipelines_backend.instrumentation import contextual_logging |
Collaborator
Author
There was a problem hiding this comment.
We can look into preventing this type of import in the future with a PR check
Contributor
|
Hmm. The module should still be imported only once. If relative imports always caused such issues, then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the import in structured_logging.py from relative to absolute to ensure that the same contextual_logging module instance is used across all imports. This fixes an issue where context metadata set in one module was not visible in another due to separate module instances having separate ContextVar objects.
This ensures LoggingContextFilter and contextual_logging.logging_context share the same _context_metadata ContextVar, allowing contextual data like container_execution_id and execution_node_ids to appear in logs.