Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions cloud_pipelines_backend/database_ops.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,54 @@
import logging
import time

import sqlalchemy
from sqlalchemy import event
from sqlalchemy.engine import Engine

from . import backend_types_sql as bts
from .instrumentation import metrics

logger = logging.getLogger(__name__)

# Slow query threshold for logging (in seconds)
_SLOW_QUERY_LOG_THRESHOLD = 1.0

# Slow query threshold for metrics (in seconds)
_SLOW_QUERY_METRIC_THRESHOLD = 0.01


@event.listens_for(Engine, "before_cursor_execute")
def _before_cursor_execute(conn, cursor, statement, parameters, context, executemany):
"""Record query start time."""
context._query_start_time = time.time()


@event.listens_for(Engine, "after_cursor_execute")
def _after_cursor_execute(conn, cursor, statement, parameters, context, executemany):
"""Track slow queries and log very slow ones."""
duration = time.time() - context._query_start_time

# Only track queries that exceed the metric threshold (10ms)
if duration > _SLOW_QUERY_METRIC_THRESHOLD:
# Extract operation type from SQL statement
operation = statement.strip().split()[0].upper() if statement else "UNKNOWN"
metrics.track_database_query_duration(
operation=operation,
duration_seconds=duration,
)

# Log very slow queries with full SQL for debugging
if duration > _SLOW_QUERY_LOG_THRESHOLD:
logger.warning(
"Slow database query detected",
extra={
"duration_seconds": duration,
"operation": (
statement.strip().split()[0].upper() if statement else "UNKNOWN"
),
"query": statement,
},
)


def create_db_engine_and_migrate_db(
Expand Down
35 changes: 35 additions & 0 deletions cloud_pipelines_backend/instrumentation/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,41 @@ def track_container_execution_duration(
)


# Database Performance Metrics
_db_query_duration_histogram = None


def get_database_performance_metrics():
"""Get or create database performance metrics."""
global _db_query_duration_histogram

meter = get_meter()
if meter is None:
return None

if _db_query_duration_histogram is None:
_db_query_duration_histogram = meter.create_histogram(
name="db_query_duration_seconds",
description="Duration of slow database queries (>10ms) in seconds",
unit="s",
)

return _db_query_duration_histogram


def track_database_query_duration(operation: str, duration_seconds: float):
"""
Track database query duration (only for slow queries >10ms).

Args:
operation: SQL operation type (select/insert/update/delete)
duration_seconds: Query duration
"""
histogram = get_database_performance_metrics()
if histogram:
histogram.record(duration_seconds, {"operation": operation.lower()})


class HTTPMetricsMiddleware(BaseHTTPMiddleware):
"""
Middleware to track HTTP request metrics.
Expand Down