fix(solid-form): fix AppField rerender when calling field function #1933

[AmeerDlshad]

Using any Signal inside the Form.AppField render function causes the entire component to re-run whenever that Signal changes.

Below is an example:

<Form.AppField name="username">
  {(field) => {
    const value = useStore(
      field().store,
      (s) => s.value,
    );
    onMount(() => {
      console.log("Mount"); // This runs every time value changes
    });
    
    console.log(value()); // This runs every time value changes
    
    return <field.TextField label={t`Username`} />;
  }}
</Form.AppField>;

Fix

By wrapping it with a createComponent this no longer happens.

<Form.AppField name="username">
  {(field) =>
    createComponent(() => {
      const value = useStore(field().store, (s) => s.value);
      onMount(() => {
        console.log("Mount");
      });
      
      console.log(value());

      return <field.TextField label={t`Username`} />;
    }, {})
  }
</Form.AppField>;

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4a9bbbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR