fix(form-core): prevent double re-render when no async validators #1929
+73
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isValidatingdoesn't toggle unnecessarilyProblem
As reported in #1130, fields were re-rendering twice on each keystroke because
isValidatingwas being set totruethen immediatelyfalseinvalidateAsync, even when there were no async validators to run.Root Cause
In
FieldApi.validateAsync:Solution
Check if there are actual async validators before toggling
isValidating:Test Plan
should not toggle isValidating when there are no async validatorsFixes #1130