consider isLoadingSubset in useLiveQuery isLoading state #1014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where useLiveQuery would return isLoading=false while data was still undefined for on-demand sync mode. This would frequently cause flicker of 'not found' type messages.
For example, I added a console.log of isLoading, data for a component I'm working on:
The useLiveQuery hook now subscribes to loadingSubset:change events and factors isLoadingSubset into the isLoading computation.
I'm not 100% sure this is the best approach to fixing this, but it seems like the best approach I could find given my relative lack of knowledge about the codebase. Happy to rework with any suggestions anyone has to resolve this.
🎯 Changes
✅ Checklist
the below do not exist but I've followed the spirt of them :)
pnpm test:pr.🚀 Release Impact