chore(QTDI-2053):use safer method to verify certificate #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypiel-talend
reviewed
Dec 8, 2025
| if (acceptAnyCertificate) { | ||
| builder.hostnameVerifier((host, session) -> true); | ||
| builder.sslContext(createUnsafeSSLContext()); | ||
| } else if (keystoreLocation.isPresent()) { |
Contributor
There was a problem hiding this comment.
Should we check if keystore is present or not, or, simply raise an exception when it is not present ? (maybe a question to @coheigea )
Member
There was a problem hiding this comment.
I assume the code falls back to the JDK defaults if the keystore isn't present? If so that would be OK, and we could just log this.
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Why this PR is needed?
What does this PR adds (design/code thoughts)?