New automation component User Interface design.#13
Open
Rajkumarpulaparthi wants to merge 34 commits intoTINF17C:masterfrom
Open
New automation component User Interface design.#13Rajkumarpulaparthi wants to merge 34 commits intoTINF17C:masterfrom
Rajkumarpulaparthi wants to merge 34 commits intoTINF17C:masterfrom
Conversation
"Create new device": Errorhandling incorrect ---Issue resolved
A basic User Interface for creating new automation component
Member
|
Unfortunatly, these changes break the functionality of the createDevice GUI. |
…trical Interface"
Member
|
Hey @Rajkumarpulaparthi! I found a few things you should change:
That's all my feedback for now. |
Author
|
Hi stefan,
Sorry for the late reply.
I'm shifting from stuttgart to back to my university. Unfortunately, I
couldn't got chance to reply.
I will consider these changes and let you know, as soon as possible.
Thank you for being active and checking. I will make changes to the plugin
once I'm done with my thesis work.
Best regards
Raj kumar
<notifications@github.com> wrote:
… Hey @Rajkumarpulaparthi <https://github.com/Rajkumarpulaparthi>!
I just found some time to look into some of the changes you made.
First of: I like the changes you made. Even though I'm not able to fully
understand how it should work, because I don't know what it's supposed to
do. But thats fine ;)
I found a few things you should change:
1. Clicking on 'Help -> Manual' opens a link to your company's
sharepoint. Since this is internal only, I don't think it should be in this
open source project. It would be great if you could publish this manual so
other people can use it as well. If you can't publish the manual, you
should remove the link in the plugin.
2. Clicking on the red cross (see screenshot) results in a
ArgumentOutOfRangeException. This occurs in the Generic Data Tab
(DeviceDescription.cs:line 2293) and the Interfaces tab
(DeviceDescription.cs:line 1989).
[image: Screenshot_error_ArgumentOutOfRangeException]
<https://user-images.githubusercontent.com/31218621/73368230-e876d280-42b0-11ea-8265-65df9e78c3e9.png>
3. When opening the plugin, the sidebar with the class libraries is
extremly small. I don't know, if this is intended. I feel, that this
sidebar could be a bit bigger at the start.
That's all my feedback for now.
Have a good day!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13?email_source=notifications&email_token=AMB5N7AS5LRZALABXXIPTFDRAGL5ZA5CNFSM4H63O2WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHQTUY#issuecomment-579799507>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMB5N7DKFNRHUYCDQ2BZBVLRAGL5ZANCNFSM4H63O2WA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Lick on Create new device button on the start GUI, A basic user Interface for with options are designed.