fix: full width article main image not stretching #1050
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given an article main image of thumbnail size with no set width, Then that image should not be shrunk less than width of content.
Given a news feed image of thumbnail size with large width, Then that image should not be shrunk less if space is available. BUG: If on grid layout (e.g. narrow screen), 300 width image too narrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Given an article main image of thumbnail size with no set width, then that image should not shrink less than width of content.
Important
Status
.blog-visual.Use a container query.
💡 Idea: Allow image size to define grid item width!
Related
Changes
Article Page
news-article-page__media--slim-context→…--layout-centernews-article-page__media--wide-context→…--layout-floatnews-article-page__media--…x-news.cssdjango.cms.blog.app.page.css…--layout-centerto be used only if main image thumb. opt. has0widthdata-widthdata-heightNews Feed
Testing
UI
…