Simplified HMAC explanation #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original HMAC explanation was somewhat convoluted. I've separated the two steps more clearly, and made sure to mention every term of the formula. Also added spacing to the outer parentheses in the formula to make it more clear where the boundary is of the outer H()
Contributor
|
Thanks, this is mostly an improvement but it does introduce a new source of confusion, since it implies that 2 applications of the hash somehow makes the hash a keyed hash. I am going to accept the PR and edit further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original HMAC explanation was somewhat convoluted. I've separated the two steps more clearly, and made sure to mention every term of the formula.
Also added spacing to the outer parentheses in the formula to make it more clear where the boundary is of the outer H()