Updatting dependencies, moving rkyv from 7 to 8 in particular#3
Closed
thestarmaker wants to merge 2 commits intoSynphonyte:mainfrom
Closed
Updatting dependencies, moving rkyv from 7 to 8 in particular#3thestarmaker wants to merge 2 commits intoSynphonyte:mainfrom
thestarmaker wants to merge 2 commits intoSynphonyte:mainfrom
Conversation
Contributor
Author
|
ah, crap, rkyv tests are not enabled without a feature, it should not have compiled |
Contributor
Author
|
okay, it should work now |
Merged
Contributor
|
Thank you very much! I fixed rustfmt in a replacement PR. Closing this in favor of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded dependencies, especially moving from
rkyv7 to 8. This is a breaking change but unit tests seem to pass. I have not done any other testing on this.This change is being done on the back of leptos-rs/leptos#3467