login with no email #409
Open
login with no email #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is kind of working. The test is submitting an email of "bademail", which doesn't fit into the regex of a valid email. Therefore, I currently have it written as a 400 error returning "Please enter a valid e-mail address". I feel this is a better response than the one in SBH1 which is a 401 stating "Your e-mail address was not recognized." |
Contributor
|
Agreed. The message could be better. |
cjmyers
approved these changes
May 19, 2023
Contributor
|
While I've approved, please fix the message and conflicts before merging. |
Contributor
|
@anjalakaturi Please update the test to use a valid email address which is not a valid user. In this case, the message should match SB1. |
Contributor
|
I just tested this on my local and I got the matching content. Not sure what the issue is, but will look into it more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #408