fixed broken variable - added duration feature#3
Open
sixfngers wants to merge 2 commits intoSybio:masterfrom
Open
fixed broken variable - added duration feature#3sixfngers wants to merge 2 commits intoSybio:masterfrom
sixfngers wants to merge 2 commits intoSybio:masterfrom
Conversation
added the ability to only pass a single frame duration for every frame
|
I think I'd prefer if a single integer is passed in as $durations in the case where the same duration should be used for all frames. Ie use is_integer($durations) and is_array($durations) to determine what user wants. Supplying an array of size 1 looks strange to me. Maybe also change the name of $durations since it's no longer an array of several durations so it could be confusing to the user. Also, don't forget to update the documentation :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using this in an upcoming project. fixed issue and added a single duration capability feature that made it a simpler usage for my project without taking away any functionality from the previous implementation