Skip to content

Conversation

@himabindugit
Copy link

PR with proper commits and messages

@@ -0,0 +1 @@
node_modules/*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @himabindugit! I'm looking forward to hearing your thoughts following my review :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rleonr-sf thanks for the detailed review, i have tried my best to answer your questions, i can take an another look tomorrow just to make i haven't missed anything.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @himabindugit, I appreciate the time invested in this submission. We'll get in touch with you with an update soon

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rleonr-sf Just FYI - I have pushed more changes. I have just included screenshots (success and error cases) using my GraphQL API, am happy to upload interactive demo with using GraphQL API.

@himabindugit
Copy link
Author

@marcelino-sf Hi, I forgot to ask one question in our call today. Code challenge README mentioned about The API should follow typical GraphQL API design patterns, other than the standards I have already followed - is there anything specific about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants