Skip to content

IN-243 Response body #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
petergaal91 wants to merge 3 commits into from
Closed

IN-243 Response body #33

petergaal91 wants to merge 3 commits into from

Conversation

@petergaal91
Copy link
Contributor

@petergaal91 petergaal91 commented Feb 9, 2026 •
edited
Loading

Checklist

  • This PR includes a change that:
    • Fixes a bug (non-breaking change)
    • Adds a new feature (non-breaking change)
    • Introduces a breaking change (fix or feature that would cause existing functionality to change)
  • I have reviewed the documentation and updated the relevant sections.
  • I have reviewed the tests and added or corrected them as necessary.

@petergaal91 petergaal91 requested a review from a team as a code owner February 9, 2026 13:14
dvhsty
dvhsty requested changes Feb 10, 2026
View reviewed changes
strivacity_flutter/lib/src/login_handler.dart
Comment on lines +73 to +77
// Try to parse response body as URL first, fall back to realUri
try {
redirectUri = Uri.parse(response.body.toString());
} catch (_) {
redirectUri = response.realUri!;
Copy link
Contributor

@dvhsty dvhsty Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern appears multiple times. There is sdk-native HttpResponse class. A computed property (getter) could easily be created to query for the redirect URL.

This would simplify and shorten code:

final redirectUri = response.redirectChainFinalUri;

Check if HttpResponse.realUri could be made library private when a getter is introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvhsty dvhsty dvhsty requested changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@petergaal91 @dvhsty