Conversation
## Fixes
* Bug where /pk ch avatar wouldn't add subelements of elements
## Misc. Changes
* Line 190 | Changed the inner loop for getting subelements of an element.
> * For the line `for (final SubElement sub : Element.getSubElements(e))`,(previous version: `for (final SubElement sub : Element.getSubElements(element))`, the getSubElements method would take the Element object outside of the for loop instead of the one needed in the outer for loop `for (Element e : new Element[] {Element.AIR, Element.EARTH, Element.FIRE, Element.WATER})`
Updates Java to 21 and Minecraft to 1.20
) ## Issue This bug prevents damage from being applied consistently when using IceSpikeBlast and IceBlast. When a player is hit with IceSpikeBlast or IceBlast during the `bPlayer.slow(slowCooldown)` the attack wouldnt pass through the `if(bPlayer.canBeSlowed())` check where the damage command for players is located. ## Additions * Adds a SlowCooldown parameter to the config under "Abilities.Water.IceBlast.SlowCooldown". * IceBlast uses new SlowCooldown parameter. ## Fixes * Line 98 IceSpikeBlast > * Moves damage out of the `canBeSlowed()` check. * Line 165 IceBlast > * Moves damage out of the `canBeSlowed()` check. ## Removals * Line 99 IceSpikeBlast > * Removes recasting of entity to get the bending player. Now uses the same method as IceSpikePillar to get the bending player.
…nt if this persists elsewhere)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.