SMODS.CardButton, universal approach to adding buttons to cards#930
Open
bepisfever wants to merge 8 commits intoSteamodded:mainfrom
Open
SMODS.CardButton, universal approach to adding buttons to cards#930bepisfever wants to merge 8 commits intoSteamodded:mainfrom
bepisfever wants to merge 8 commits intoSteamodded:mainfrom
Conversation
Collaborator
|
This is a very large amount of code. I'm concerned just on those grounds, simplifying it will help this PR the most I think This PR is undeniably useful, I like it. Integrating DrawStep in is solid work, logic there looks clear. Code review: Unfortunately I cannot check the correctness of the code easily, I'll just have to take your word for it. The rest of the code is difficult to read. Also, could you add quick comments on each function and some comments inside functions to summarize what the code in there is doing. that should help this PR, being able to skip over the dense ui tables More comments: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
SMODS.CardButton, which allows you to add buttons to cards much more easily. It also auto-aligns added buttons.Code example:
Additional Info: