Conversation
refeed
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just have one comment for now
|
@refeed, The requested change have been successfully implemented |
refeed
left a comment
There was a problem hiding this comment.
There are tests failing, you need to import first the types before using it, e.g. from typing import List etc
https://github.com/StackGuardian/tirith/actions/runs/11470298982/job/31933623911?pr=198#step:5:733
|
Thanks for pointing that out! I'll make sure to import the necessary types before using them. I'll fix the tests and update the code accordingly. |
|
@refeed I have fixed the error. Please review it. |
|




Pull Request Template
#180
Description
What changes are being made?
Why are these changes necessary?
Which issues or tickets does this PR close or relate to?
Type of Change
Checklist
Screenshots or Recordings (if applicable)
Additional Information