Open
Conversation
Collaborator
taherkk
commented
May 2, 2025
taherkk
commented
- Changes to output azure logs to golang utility in case there is auth provided
- Add config in fluentbit to read from the head of a file
| cp sgrunner /opt/sgrunner/sgrunner | ||
|
|
||
| mkdir -p /var/log/sgrunner/ | ||
| mkdir -p /etc/sgrunner |
There was a problem hiding this comment.
Couldnt we do this in one go?
Suggested change
| mkdir -p /etc/sgrunner | |
| mkdir -p /var/log/sgrunner /etc/sgrunner |
Collaborator
Author
There was a problem hiding this comment.
We could but it is easier for debugging
larisoncarvalho
approved these changes
May 8, 2025
Akshat0694
reviewed
May 15, 2025
main.sh
Outdated
| Name http | ||
| Match_Regex orgs** | ||
| Host 10.0.0.62 | ||
| Port 8080 |
Member
There was a problem hiding this comment.
safe to hardcode the IP and port? Surely won't conflicts? Maybe use private ports between: 49152-65535? Refer to https://arubanetworking.hpe.com/techdocs/AOS-S/16.10/ATMG/KB/content/kb/tcp-por-num-ran.htm#:~:text=There%20are%20three%20ranges%3A,and%20Private%20Ports%3A%2049152%20%2D%2065535
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.