-
Notifications
You must be signed in to change notification settings - Fork 8
add a 404 page #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a 404 page #62
Conversation
Signed-off-by: Yufa <112290188+01001101CK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Hi @01001101CK, thanks for the pull request! A scan flagged a concern with it. Could you please take a look? [pr-branch-non-default] This PR is sent from the head repository's default branch Sending a PR from a default branch means the head repository can't easily be updated after the PR is merged. Sending a PR from a repository's default branch, commonly
|
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey this is lovely, thank you! 🙌
The text is clever and I like the design. It feels like a great balance of being "computer knowledgeable" while still approachable and friendly. Nice.
I'm requesting changes on two points:
- There's a lot of added CSS here. I think you can shrink it down a bunch by using existing colors and avoiding dark-mode-specific styles
- The design has a lot of brightness in dark mode, which we'll have to avoid
LMK if any of that doesn't make sense, I'm happy to pair!
…pecific .dark theme
|
Closing in favor of #65 as discussed privately, which is off a different branch than |
PR Checklist
Overview
Demo
Screen.Recording.2025-09-04.at.4.04.33.PM.mov