Skip to content

Conversation

@01001101CK
Copy link

PR Checklist

Overview

  • add a 404 page

Demo

Screen.Recording.2025-09-04.at.4.04.33.PM.mov

Signed-off-by: Yufa <112290188+01001101CK@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Sep 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
squiggleconf Ready Ready Preview Comment Sep 16, 2025 9:37pm

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

👋 Hi @01001101CK, thanks for the pull request! A scan flagged a concern with it. Could you please take a look?

[pr-branch-non-default] This PR is sent from the head repository's default branch Sending a PR from a default branch means the head repository can't easily be updated after the PR is merged. Sending a PR from a repository's default branch, commonly main, means that repository will have a hard time pulling in updates from the upstream repository. It's generally recommended to instead create a new branch per pull request. You'll need to:

  1. Create a new branch on your fork
  2. Send a new pull request from that branch
  3. Close this pull request

🗺️ This message was posted automatically by OctoGuide: a bot for GitHub repository best practices.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this is lovely, thank you! 🙌

The text is clever and I like the design. It feels like a great balance of being "computer knowledgeable" while still approachable and friendly. Nice.

I'm requesting changes on two points:

  • There's a lot of added CSS here. I think you can shrink it down a bunch by using existing colors and avoiding dark-mode-specific styles
  • The design has a lot of brightness in dark mode, which we'll have to avoid

LMK if any of that doesn't make sense, I'm happy to pair!

@JoshuaKGoldberg
Copy link
Member

Closing in favor of #65 as discussed privately, which is off a different branch than main. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting for author Needs an action taken by the original poster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants