[solver-constraint] Rename epsilon by energyWeight#77
Open
EulalieCoevoet wants to merge 2 commits intoSofaDefrost:mainfrom
Open
[solver-constraint] Rename epsilon by energyWeight#77EulalieCoevoet wants to merge 2 commits intoSofaDefrost:mainfrom
EulalieCoevoet wants to merge 2 commits intoSofaDefrost:mainfrom
Conversation
Collaborator
|
I would advise to use a compatibility layer to avoid breaking scenes/tutorials that would not have been updated As example is available in https://github.com/sofa-framework/sofa/pull/5518/changes (see the class CollisionModel) |
Collaborator
|
I would suggest to use an homogeneous way to manage the lifecycle in all codes : This would avoid the boiler plate code in the init ;) @bakpaul will test this PR soon with his new sofa-test-action ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When solving an inverse problem, we add a term in the optimization cost function that minimizes the actuation energy. This is achieved by regularizing the QP matrix
Qthrough the addition ofepsilon*Waa, whereepsilonis selected to be sufficiently small to avoid disrupting the quality of the effector positioning.Problem:
We named this parameter
epsilon, which isn't clear to users.In this PR:
epsilontoenergyWeightin both the C++ code and user APIAlso:
objectivedata, set it as read-only, and change its default value to 0rebuildSystem()methodNeeds: SofaDefrost/SoftRobots#344