fixed bug that leads to 1D linear material not behaving properly in simulations#108
Open
JRao-rgb wants to merge 3 commits intoSimVascular:masterfrom
Open
fixed bug that leads to 1D linear material not behaving properly in simulations#108JRao-rgb wants to merge 3 commits intoSimVascular:masterfrom
JRao-rgb wants to merge 3 commits intoSimVascular:masterfrom
Conversation
…n copying a line over, and I didn't realize. Hopefully it builds now?
Author
|
@mrp089 should be good to merge! Please take a look when you get time. |
mrp089
requested changes
Nov 17, 2023
Member
There was a problem hiding this comment.
Check out this file from master branch because there are only formatting changes in here
Member
There was a problem hiding this comment.
Would it make sense to do one of these tests with " So_/S would always be close to one, right?
|
|
||
| void cvOneDMaterialLinear::SetEHR(double ehr_val, double pref_val){ | ||
| ehr = ehr_val; | ||
| ehr = 4.0/3.0*ehr_val; // JR 15/11/23: multiplied EHR by the correct factor (since downstream analysis using EHR |
Member
There was a problem hiding this comment.
No need to add date and initials (even though people did it before), that's now all stored in git. You can check it out by doing a git blame on a file.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
#110
I found out the linear material model is broken when I was testing the backwards compatibility of the leaky vessels code with previous sv input files. I initially thought it was my code that was broken, but the code just didn't handle linear materials properly.
Release Notes
Documentation
Testing
Please ensure that the PR meets the testing requirements set by GitHub Actions.
Code of Conduct & Contributing Guidelines