Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors block pruning from an automatic passive operation (via WithPruneTarget option) to an active manual operation (via PruneBlocks method). The change aims to fix a race condition where blocks were pruned before chain subscribers could index them, by giving integrators explicit control over when pruning occurs.
Changes:
- Removed
WithPruneTargetmanager option and automatic pruning logic from the chain manager - Added new
PruneBlocks(height)method that allows manual pruning of blocks below a specified height - Updated
synccommand to manually callPruneBlocksafter each reorg event - Added test coverage for the new pruning functionality
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| chain/options.go | Removes the WithPruneTarget option function |
| chain/manager.go | Removes automatic pruning from applyTip and adds new PruneBlocks method for manual pruning |
| internal/cmd/sync/main.go | Updates reorg channel to pass ChainIndex and calls PruneBlocks manually after each reorg |
| internal/cmd/calcswaps/main.go | Removes usage of WithPruneTarget option |
| chain/db_test.go | Adds test for the new PruneBlocks functionality |
| .changeset/*.md | Documents the breaking change with appropriate version bump |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChrisSchinnerl
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a race condition on some nodes when chain subscribers are slow where blocks would be removed from the store before they could be indexed.