Skip to content

Fix webtransport conn not being served due to missing EnableStreamResetPartialDelivery#392

Merged
n8mgr merged 4 commits intomasterfrom
chris/fix-webtransport
Feb 4, 2026
Merged

Fix webtransport conn not being served due to missing EnableStreamResetPartialDelivery#392
n8mgr merged 4 commits intomasterfrom
chris/fix-webtransport

Conversation

@ChrisSchinnerl
Copy link
Member

Seems like a new requirement for webtransport-go.

Relevant code can be found here.

Closes #391

Copilot AI review requested due to automatic review settings February 3, 2026 17:48
@github-project-automation github-project-automation bot moved this to In Progress in Sia Feb 3, 2026
@ChrisSchinnerl ChrisSchinnerl changed the title Chris/fix webtransport Fix webtransport conn not being served due to missing EnableStreamResetPartialDelivery Feb 3, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes WebTransport connection issues by enabling EnableStreamResetPartialDelivery in QUIC configurations, which is a new requirement from webtransport-go. The change also improves error logging for WebTransport connections.

Changes:

  • Added EnableStreamResetPartialDelivery: true to both client (Dial) and server (Listen) QUIC configurations
  • Enhanced error logging for WebTransport connection failures with more specific error messages
  • Improved consistency in error log messages between WebTransport and QUIC connection handling

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
rhp/v4/quic/quic.go Enables EnableStreamResetPartialDelivery for both client and server QUIC configs; adds error logging for ServeQUICConn and clarifies log messages
.changeset/enable_streamresetpartialdelivery_when_listening_for_quic_connections.md Documents the change as a patch-level update

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ChrisSchinnerl ChrisSchinnerl self-assigned this Feb 3, 2026
@Alrighttt
Copy link

Did you intentionally leave out the call to webtransport.ConfigureHTTP3Server() I mentioned in the issue? I get a handshake failure when trying CONNECT using your version.

Copy link
Member

@n8mgr n8mgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to call webtransport.ConfigureHTTP3Server as described in the issue?

@ChrisSchinnerl
Copy link
Member Author

@Alrighttt @n8mgr no that was a mistake. I added a regression test toe make sure it works and doesn't break itself again without us knowing.

@ChrisSchinnerl ChrisSchinnerl requested a review from n8mgr February 4, 2026 09:04
Copy link

@Alrighttt Alrighttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n8mgr n8mgr force-pushed the chris/fix-webtransport branch from a2977a7 to 95df8ef Compare February 4, 2026 20:36
@n8mgr n8mgr merged commit 830daa8 into master Feb 4, 2026
11 checks passed
@n8mgr n8mgr deleted the chris/fix-webtransport branch February 4, 2026 20:37
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sia Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

WebTransport listener is misconfigured

5 participants