Draft
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the go.sia.tech/core dependency to align with upstream changes that remove the MaxCollateral parameter from validation methods in the RHP v4 protocol. The changes are part of a broader refactor to switch from max collateral to max contract size constraints.
Changes:
- Updated
go.sia.tech/coredependency to version 0.19.1-0.20260122000638-bfbefbf60715 - Removed
MaxCollateralparameter from threeValidate()method calls in RHP v4 contract operations - Added changeset documentation for the minor version bump
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates core dependency to new version with API changes |
| go.sum | Updates checksums for the new core dependency version |
| rhp/v4/server.go | Removes MaxCollateral parameter from FormContract, RefreshContract, and RenewContract validation calls |
| .changeset/switched_to_max_contract_size.md | Documents the change for release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires SiaFoundation/core#380