Fix incorrect node index handling and prevent duplicate node insertions in RemoteMutationObserver#561
Open
mfal wants to merge 10 commits intoShopify:mainfrom
Open
Fix incorrect node index handling and prevent duplicate node insertions in RemoteMutationObserver#561mfal wants to merge 10 commits intoShopify:mainfrom
RemoteMutationObserver#561mfal wants to merge 10 commits intoShopify:mainfrom
Conversation
RemoteMutationObserver
64790d8 to
57b17df
Compare
Author
|
Hey @lemonmade! It's been quite a long time since I created this PR, so I would be very happy if you (or someone else) could keep an eye on this. The MR does involve a big change, but I think it's all well structured and tested. There is also a test case that shows that the current implementation leads to errors. The linked issue also contains valuable information. By the way, we have been running a fixed fork in a relatively extensive scenario for some time without any errors 😄 Thanks! |
2f58f8e to
757ece9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in
RemoteMutationObserverwhere incorrect node indices led to improper insertion and removal of nodes, particularly in cases where multiple mutation records were processed in a single event.In rare edge cases, nodes were being inserted multiple times on the host. Although the previous logic attempted to guard against this using addedNode.contains(node), it failed in scenarios where deeply nested replacements occurred. This check only considers direct descendants.
Changes Introduced:
Why this is needed:
contains()method on the parent node, which only finds direct descendants.These changes significantly improve the correctness and resilience of RemoteMutationObserver in complex mutation scenarios, while maintaining good performance characteristics.
Resolves #560