refactor cli-kit to vertical slices of shopify product domains#6855
Open
ryancbahan wants to merge 8 commits intomainfrom
Open
refactor cli-kit to vertical slices of shopify product domains#6855ryancbahan wants to merge 8 commits intomainfrom
ryancbahan wants to merge 8 commits intomainfrom
Conversation
ryancbahan
force-pushed
the
ryan/cli-kit-domain-refactor
branch
from
46c759d to
0b16ad7
Compare
This comment has been minimized.
This comment has been minimized.
ryancbahan
force-pushed
the
ryan/cli-kit-domain-refactor
branch
from
0b16ad7 to
3bd6aa0
Compare
Contributor
Coverage report
Test suite run success3771 tests passing in 1453 suites. Report generated by 🧪jest coverage report action from 13ef0dd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The cli kit section does not have a directory structure that lends itself well to team ownership boundaries. This PR is a no-op overhaul of code geography to provide a top-level structure that splits concerns by Shopify product/domain so that clearer boundaries can be established.
Before:
After:
This is the first step of many. The work ahead would be to better organize the
shareddirectory, and to ensure our primitives are isolated and composable (right now things likesessionandfqdnare multi-domain "god objects" that need to be effectively split). We also need to consider how we manage cross-domain dependency. But I believe this change introduces a feasible path forward to better ownership and stewardship.WHAT is this pull request doing?
Behavioral no-op. Establishing a clear set of conventions and semantics for how to organize code in the CLI.
How to test your changes?
We're gonnsa have to test basically everything. Sorry/not sorry, let's rip this bandaid.
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist