Skip to content

suppress otel errors in console #6850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aswamy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

suppress otel errors in console #6850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plenty-snails-return.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/cli-kit': patch
---

[internal] suppress console errors when pushing metrics
5 changes: 4 additions & 1 deletion packages/cli-kit/src/private/node/otel-metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
DefaultOtelServiceOptions,
} from '../../public/node/vendor/otel-js/service/DefaultOtelService/DefaultOtelService.js'
import {isUnitTest, opentelemetryDomain} from '../../public/node/context/local.js'
import {ValueType} from '@opentelemetry/api'
import {ValueType, diag} from '@opentelemetry/api'

type MetricRecorder =
| 'console'
Expand Down Expand Up @@ -150,6 +150,9 @@ function globalOtelService(options: CreateMetricRecorderOptions): OtelService {
env: undefined,
otelEndpoint: `${opentelemetryDomain()}/v1/metrics`,
})
// Suppress OTEL diagnostic output — internal export errors (e.g. retryable failures)
// should never appear in user-facing CLI output.
diag.disable()
}
return _otelService
}
Expand Down
6 changes: 6 additions & 0 deletions packages/cli-kit/src/public/node/vendor/otel-js/utils/throttle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ export function throttle<T extends (...args: any) => any>(
timeout = null
if (lastArgs) {
result = func.apply(context, lastArgs)
// If the throttled function returns a promise, swallow rejections to
// prevent unhandled promise rejections (the caller already .catch()'d
// the leading-edge invocation and has no reference to trailing calls).
if (result && typeof (result as any).catch === 'function') {
(result as any).catch(() => {})
}
}
context = null
lastArgs = null
Expand Down
Loading