[Ramses][AMR] Get amr levels #1419
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Ramses][Solvergraph] AMR level zero sizes Added a solvergraph node to compute level zero sizes for each patch. This will be used for instance to compute the amr level for blocks in each patch. updates
Summary of ChangesHello @Akos299, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces functionality to determine the Adaptive Mesh Refinement (AMR) levels for all simulation blocks within a patch. It achieves this by first computing the base cell size at level 0 for each patch and then utilizing this, alongside block boundary information, to derive the specific AMR level for individual blocks. This enhancement provides crucial data for understanding the refinement structure of the simulation grid. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the capability to compute AMR levels for blocks within a patch. It adds a new ComputeLevel0CellSize node and utilizes the existing ComputeAMRLevel node. The changes are well-structured and integrate cleanly into the existing solver graph. My review includes suggestions to improve maintainability by removing a duplicated type definition and providing descriptive names for a newly created solver graph field, which will aid in debugging and visualization.
[Ramses][AMR] AMR levels Get AMR levels for all blocks in each patch. This is done by using the ComputeAMRLvel node implemented by @tdavidcl. updates
Akos299
force-pushed
the
features/get-amr-levels
branch
from
6f0785d to
a977735
Compare
Workflow reportworkflow report corresponding to commit b1e8e60 Light CI is enabled. This will only run the basic tests and not the full tests. Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Doxygen diff with
|
tdavidcl
reviewed
Dec 27, 2025
| std::make_shared<decltype(node_level0_sizes)>(std::move(node_level0_sizes))); | ||
| } | ||
|
|
||
| { // compute block amr level in patch |
Member
There was a problem hiding this comment.
similarely to #1418 this should be enabled based on the solverconfig. For the base solver this is not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the AMR levels of all blocks in a patch.
For this we use the ComputeAMRLevel node implemented by @tdavidcl.
TODO: Add possibility in the binding to get the amr levels at post-treatment stage.