Skip to content

Conversation

@mlesfield
Copy link

tests not passed due to "tox" issue

@xguse
Copy link
Member

xguse commented Oct 26, 2017

OK so generally, you dont want to submit PRs to master. We can think of master as only changing when we do a "release". It should jump ahead to the next release each time while develop makes gradual incremental steps forward until we are happy with things enough to make another 'release'.

Also, the travis checks didn't pass which means that we still have some work to do. I think that I am going to go ahead and accept this PR, fix the problems and reset master back to v0.0.5.

Congratulations though. Your first accepted PR!

@mlesfield
Copy link
Author

yeah, sorry. I was staring at the flow you gave me earlier last year, but I didn't think to switch the branch from the master default. Will switch to develop in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants