[STORY-3093] feat(dbng): add firewall rules commands #1171

briceamen · 2025-12-31T10:52:09Z

Summary

Add firewall rules management commands for DBNG databases:

database-firewall-rules - List firewall rules
database-firewall-rules-add - Add custom CIDR or managed range rule
database-firewall-rules-remove - Remove a rule
database-firewall-managed-ranges - List available managed ranges

Commands support both positional arguments and --database flag, matching existing DBNG command patterns (database-info, database-destroy).

Usage examples

# Positional argument style
scalingo database-firewall-rules my-db-id
scalingo database-firewall-rules-add my-db-id --cidr 203.0.113.0/24 --label "Office"
scalingo database-firewall-rules-remove my-db-id rule-id

# --database flag style
scalingo --database my-db database-firewall-rules
scalingo --database my-db database-firewall-rules-add --managed-range man-osc-fr1-egress
scalingo --database my-db database-firewall-rules-remove rule-id

Changes

Added GetAddonIDFromDatabase helper in detect/app.go to resolve addon ID from database ID
Firewall commands now support positional args like other DBNG commands

Test plan

Tested on staging (osc-st-fr1) with database test-firewall-rules-db:

Positional argument style:

database-firewall-rules test-firewall-rules-db - List rules
database-firewall-managed-ranges test-firewall-rules-db - List managed ranges
database-firewall-rules-add test-firewall-rules-db --cidr 203.0.113.0/24 --label "Test office" - Add custom rule
database-firewall-rules-remove test-firewall-rules-db <rule-id> - Remove rule

--database flag style:

--database test-firewall-rules-db database-firewall-rules - List rules
--database test-firewall-rules-db database-firewall-rules-add --managed-range man-osc-st-fr1-egress - Add managed range
--database test-firewall-rules-db database-firewall-rules-remove <rule-id> - Remove rule

notion-workspace · 2025-12-31T10:52:16Z

🗒️ [FEAT] Implement Firewall Rules on CLI

…mands

sc-david-voisin

Looks good to me, however I have few questions/suggestions

detect/app.go

dbng/firewall_rules.go

sc-david-voisin · 2025-12-31T14:38:37Z

dbng/firewall_rules.go

+	}
+
+	io.Statusf("Firewall rule '%s' has been added to database '%s'.\n", rule.ID, databaseID)
+	io.Warning("Firewall rules take time to be applied due to infrastructure provisioning.")


Maybe reformulate a bit. A proposition:

"Expect some delay for the firewall rules to be applied, due to infrastructure provisioning."

dbng/firewall_rules.go

detect/app.go

matthieu526-scalingo · 2026-01-02T10:49:46Z

cmd/firewall_rules.go

+				return cli.ShowCommandHelp(ctx, c, "database-firewall-rules")
+			}
+
+			utils.CheckForConsent(ctx, databaseID, utils.ConsentTypeDBs)


question: is the consent required here?

matthieu526-scalingo · 2026-01-02T10:51:45Z

cmd/firewall_rules.go

+			switch c.Args().Len() {
+			case 0:
+				// No positional arg, database from --database flag
+				databaseID, addonID = detect.GetCurrentDatabase(ctx, c)
+			case 1:
+				// database-id provided as positional arg
+				databaseID = c.Args().First()
+				addonID, err = detect.GetAddonIDFromDatabase(ctx, databaseID)
+				if err != nil {
+					errorQuit(ctx, err)
+				}
+			default:
+				io.Error("Too many arguments")
+				return cli.ShowCommandHelp(ctx, c, "database-firewall-rules-add")
+			}


question: this is done 3 times? What do you about about making a small function out it?

matthieu526-scalingo · 2026-01-02T10:52:47Z

cmd/firewall_rules.go

+			} else {
+				params = scalingo.FirewallRuleCreateParams{
+					Type:    scalingo.FirewallRuleTypeManagedRange,
+					RangeID: managedRange,


question: here the label isn't used, is it on purpose? Otherwise, shouldn't we block the flag for manages rules?

matthieu526-scalingo · 2026-01-02T10:54:19Z

cmd/firewall_rules.go

+
+			utils.CheckForConsent(ctx, databaseID, utils.ConsentTypeDBs)
+
+			err = dbng.FirewallManagedRangesList(ctx, databaseID, addonID)


question: why do you need the DB ID to list the ranges?

matthieu526-scalingo · 2026-01-02T10:56:08Z

dbng/firewall_rules.go

+	}
+
+	io.Statusf("Firewall rule '%s' has been added to database '%s'.\n", rule.ID, databaseID)
+	io.Warning("Expect some delay for the firewall rules to be applied, due to infrastructure provisioning.")


question: is this the good wording? We are not really provisioning anything at this point/

matthieu526-scalingo · 2026-01-02T10:56:40Z

dbng/firewall_rules.go

+	}
+
+	io.Statusf("Firewall rule '%s' has been removed from database '%s'.\n", ruleID, databaseID)
+	io.Warning("Expect some delay for the firewall rules to be applied, due to infrastructure provisioning.")


nitpick: do we want to use applied here?

feat(dbng): add firewall rules commands for DBNG databases

b4cadcb

briceamen requested a review from Copilot December 31, 2025 10:53

This comment was marked as outdated.

Sign in to view

refactor: improve column header clarity in firewall rules list

9efbce0

briceamen self-assigned this Dec 31, 2025

feat(dbng): add positional arg support for firewall rules commands

c7a5475

briceamen requested a review from Copilot December 31, 2025 13:26

This comment was marked as outdated.

Sign in to view

fix: add validation for multiple addons in GetAddonIDFromDatabase

27dc5a3

briceamen marked this pull request as ready for review December 31, 2025 13:28

refactor: use switch statements for argument handling in firewall com…

ea3aaaa

…mands

briceamen force-pushed the feat/STORY-3093/firewall-rules branch from 10d0d9a to ea3aaaa Compare December 31, 2025 13:39

briceamen requested a review from Copilot December 31, 2025 13:40

This comment was marked as outdated.

Sign in to view

fix: improve error messages for remove command argument validation

66c53d4

briceamen requested review from curzolapierre, matthieu526-scalingo and sc-david-voisin December 31, 2025 14:02

sc-david-voisin reviewed Dec 31, 2025

View reviewed changes

briceamen added 2 commits December 31, 2025 15:50

docs: clarify addon list comment for DBNG databases

872f60e

fix: improve warning message wording for firewall rules

cf2bad7

briceamen requested a review from sc-david-voisin December 31, 2025 14:56

sc-david-voisin approved these changes Dec 31, 2025

View reviewed changes

dbng/firewall_rules.go Show resolved Hide resolved

detect/app.go Outdated Show resolved Hide resolved

matthieu526-scalingo reviewed Jan 2, 2026

View reviewed changes


		utils.CheckForConsent(ctx, databaseID, utils.ConsentTypeDBs)

		err = dbng.FirewallManagedRangesList(ctx, databaseID, addonID)

[STORY-3093] feat(dbng): add firewall rules commands #1171

Are you sure you want to change the base?

[STORY-3093] feat(dbng): add firewall rules commands #1171

Uh oh!

Conversation

briceamen commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Usage examples

Changes

Test plan

Uh oh!

notion-workspace bot commented Dec 31, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

sc-david-voisin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sc-david-voisin Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

matthieu526-scalingo Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

matthieu526-scalingo Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

matthieu526-scalingo Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

matthieu526-scalingo Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

matthieu526-scalingo Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

matthieu526-scalingo Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

briceamen commented Dec 31, 2025 •

edited

Loading