Solved Arai60/78. Subsets #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oda
reviewed
Dec 19, 2025
| ## Step 3. Final Solution | ||
|
|
||
| - 再帰での実装を練習 | ||
| - List_A += List_Bを関数内関数で行うとエラー |
There was a problem hiding this comment.
nonlocal List_A がいります。
+= は iadd が定義されていれば iadd なければ add を使って足し算と代入をするという仕組みなので参照先を変更する可能性があるので必要です。
近い話としては、このあたり。
https://docs.google.com/document/d/11HV35ADPo9QxJOpJQ24FcZvtvioli770WWdZZDaLOfg/edit?tab=t.0#heading=h.jwt99kks0w2
nodchip
reviewed
Dec 21, 2025
| for subset in all_subsets]) | ||
| if index_to_add + 1 < len(nums): | ||
| add_subsets(index_to_add + 1) | ||
| all_subsets = [[]] |
There was a problem hiding this comment.
inner function 内で使用されている変数が、 inner function より後に定義されていると、変数の定義を探すために上下に目線が移動します。これは読み手にとってやや煩わしく感じます。 inner function の中で使用する変数は、 inner function より前に定義することをお勧めします。
tokuhirat
reviewed
Jan 5, 2026
Comment on lines
+11
to
+12
| same_size_subsets = [[]] | ||
| subsets = [] |
There was a problem hiding this comment.
細かいですが、subsets の方が重要な変数だと思うので先に書きたい、また重要に見えるような変数名にしたい、と思いました。メソッド名とかぶっているのも気になりました。下で書かれている all_subsets はわかりやすいです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題文：https://leetcode.com/problems/subsets/description/