Modernize CI: Upgrade to lukka/run-cmake@v10 with CMakePresets.json #429

Sapd · 2025-10-29T21:51:42Z

Replaces the outdated lukka/run-cmake@v3 with v10

Replaces the outdated lukka/run-cmake@v3 with v10, which uses the modern CMakePresets.json approach for standardized build configuration. Changes: - Add CMakePresets.json with default configure/build/test presets - Upgrade lukka/run-cmake from v3 to v10 - Remove lukka/get-cmake (no longer needed, CMake is pre-installed) - Simplify workflow by using presets instead of manual parameters - Remove unused environment variables (buildDir, triplet) - Remove debug directory listing steps Benefits: - Presets can be used locally: cmake --preset=default - Consistent build config between local dev and CI - Better error reporting and annotations from v10 - Cleaner, more maintainable workflow Tested locally with all presets working correctly.

@v10

Unifies build workflows and updates all workflows to use modern actions. Changes: 1. Unified Build Workflow: - Merge build.yml and build-windows.yml into single workflow - Use matrix strategy for Linux, macOS, and Windows - Consistent artifact uploads across all platforms - Linux/macOS use lukka/run-cmake@v10 with CMakePresets - Windows uses direct CMake commands (better for MSYS2) 2. Continuous Release Workflow: - Upgrade lukka/run-cmake@v3 → @v10 - Use CMakePresets.json for consistency 3. Whitespace Check Workflow: - Update actions/checkout@v2 → @v4 - Update actions/github-script@v3 → @v7 - Fix deprecated ::set-output syntax → $GITHUB_OUTPUT - Update to github.rest API Benefits: - Single unified build workflow (easier maintenance) - All workflows use latest action versions - Consistent build configuration via CMakePresets - Better artifact handling across all platforms - No deprecated syntax warnings

Replaces basic check workflows with modern actions that provide detailed inline comments, annotations, and helpful fix instructions on PRs. Clang-Format Check Improvements: - Replace DoozyX/clang-format-lint with cpp-linter-action@v2 - Provides inline annotations on formatting issues - Posts PR review comments with exact locations - Shows workflow step summary - Only runs on C/H file changes (performance optimization) - Uses clang-format version 18 (matches local dev environment) Whitespace Check Improvements: - Complete rewrite with better error reporting - Posts formatted PR comment with all whitespace errors - Updates existing comment instead of creating duplicates - Includes "how to fix" instructions with exact commands - Shows workflow step summary with results - Modern permissions model (contents: read, pull-requests: write) - Better error handling and output formatting Benefits: - Contributors see exactly what's wrong and where - Clear instructions on how to fix issues - Single updated comment per PR (not comment spam) - Workflow summaries for quick status check - Professional, helpful error messages

This file contains deliberate code style issues to test the new clang-format and whitespace check workflows: Formatting issues (will be caught by cpp-linter): - Missing spaces around operators (a,int b,int c) - Missing spaces in if statement (if(a>b)) - Incorrect brace placement - No spaces around operators (x=1+2+3) - Inconsistent spacing (int param ) Whitespace issues (will be caught by whitespace check): - Trailing whitespace on lines 13 and 15 - Mixed tabs and spaces on line 21 This file is not included in CMakeLists.txt, so it won't affect the build. It exists purely to trigger the PR check workflows and demonstrate their new detailed comment features. Note: This should be removed before merging to master.

github-actions · 2025-10-29T22:27:37Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v18.1.3) reports: 1 file(s) not formatted

src/test_workflow_checks.c

clang-tidy (v18.1.3) reports: 8 concern(s)

src/test_workflow_checks.c:6:1: warning: [llvmlibc-restrict-system-libc-headers]

system include stdio.h not allowed
```
    6 | #include <stdio.h>
      | ^~~~~~~~~~~~~~~~~~
    7 | 
```
src/test_workflow_checks.c:9:34: warning: [readability-identifier-length]

parameter name 'a' is too short, expected at least 3 characters
```
    9 | int badly_formatted_function(int a,int b,int c) {
      |                                  ^
```

src/test_workflow_checks.c:9:36: warning: [bugprone-easily-swappable-parameters]

2 adjacent parameters of 'badly_formatted_function' of similar type ('int') are easily swapped by mistake

    9 | int badly_formatted_function(int a,int b,int c) {
      |                                    ^~~~~~~~~~~
/home/runner/work/HeadsetControl/HeadsetControl/src/test_workflow_checks.c:9:40: note: the first parameter in the range is 'b'
    9 | int badly_formatted_function(int a,int b,int c) {
      |                                        ^
/home/runner/work/HeadsetControl/HeadsetControl/src/test_workflow_checks.c:9:46: note: the last parameter in the range is 'c'
    9 | int badly_formatted_function(int a,int b,int c) {
      |                                              ^

src/test_workflow_checks.c:9:40: warning: [readability-identifier-length]

parameter name 'b' is too short, expected at least 3 characters
```
    9 | int badly_formatted_function(int a,int b,int c) {
      |                                        ^
```

src/test_workflow_checks.c:9:46: warning: [misc-unused-parameters]

parameter 'c' is unused

    9 | int badly_formatted_function(int a,int b,int c) {
      |                                              ^

src/test_workflow_checks.c:9:46: warning: [readability-identifier-length]

parameter name 'c' is too short, expected at least 3 characters

src/test_workflow_checks.c:10:23: warning: [llvm-else-after-return]

do not use 'else' after 'return'

   10 |     if(a>b){return a;}else{return b;}
      |                       ^~~~~~~~~~~~~~~
      |                       eturn b;

src/test_workflow_checks.c:15:9: warning: [readability-identifier-length]

variable name 'x' is too short, expected at least 3 characters
```
   15 |     int x=1+2+3;  
      |         ^
```

Have any feedback or feature suggestions? Share it here.

Implements smart caching for package managers across all platforms, reducing build times by 1-2 minutes and saving bandwidth. Linux (apt): - Caches /var/cache/apt/archives - Cache key based on workflow file hash - Fallback to most recent cache macOS (Homebrew): - Caches Homebrew downloads and cellar - Caches hidapi specifically (most common dependency) - Supports both Intel (/usr/local) and Apple Silicon (/opt/homebrew) Windows (MSYS2): - Already has built-in caching in msys2/setup-msys2@v2 - No additional configuration needed Benefits: - Faster builds (especially on macOS with Homebrew) - Reduced network usage - Lower CI costs - Better developer experience Cache invalidation: - When workflow file changes (forces fresh dependencies) - After 7 days of inactivity (GitHub's default) - Manual cache deletion via GitHub UI

Major improvements to the automated continuous build and release process, making downloads smaller, more secure, and better documented. Changes: 1. Fixed Issues: - Fixed typo: "Continuos" → "Continuous" - Fixed misleading step name (was "Download Windows Artifact") - Added workflow file itself to trigger paths 2. Binary Optimization: - Strip debug symbols from all binaries (30-50% size reduction) - Use Release build mode explicitly - Maximum compression (zip -9) 3. Security & Verification: - Generate SHA256 checksums for all downloads - Include checksums in release notes - Users can verify download integrity 4. Better Release Documentation: - Auto-generated changelog with recent commits - Direct download links for each platform - SHA256 checksums displayed prominently - Build commit SHA included - Professional formatting 5. Improved Artifacts: - Include checksums in artifact uploads - Set 90-day retention policy (save storage costs) - Better artifact organization 6. Modern Release Action: - Replace crowbarmaster/GH-Automatic-Releases with ncipollo/release-action - Official action with better maintenance - Cleaner artifact management (removeArtifacts: true) - Proper permissions model Benefits: - Smaller downloads (stripped binaries) - Verifiable downloads (SHA256 checksums) - Better release notes (auto-generated) - Lower storage costs (90-day retention) - More professional presentation

sonarqubecloud · 2025-12-17T19:30:07Z

Quality Gate failed

Failed conditions
5 Security Hotspots

See analysis details on SonarQube Cloud

Sapd added 4 commits October 29, 2025 22:45

Sapd added 2 commits October 29, 2025 23:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Modernize CI: Upgrade to lukka/run-cmake@v10 with CMakePresets.json #429

Modernize CI: Upgrade to lukka/run-cmake@v10 with CMakePresets.json #429

Uh oh!

Sapd commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

sonarqubecloud bot commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Modernize CI: Upgrade to lukka/run-cmake@v10 with CMakePresets.json #429

Are you sure you want to change the base?

Modernize CI: Upgrade to lukka/run-cmake@v10 with CMakePresets.json #429

Uh oh!

Conversation

Sapd commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Cpp-Linter Report ⚠️

Uh oh!

sonarqubecloud bot commented Dec 17, 2025

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants