Skip to content

fix(Breakout, DevContainer): Adjust to updated SWR.de layout #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awesomephant merged 3 commits into from
Dec 30, 2025
Merged

fix(Breakout, DevContainer): Adjust to updated SWR.de layout #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9f2e4a
Adjust DevContainer at top breakpoint
awesomephant Dec 30, 2025
c2e788e
Breakout/medium: Drop top breakpoint
awesomephant Dec 30, 2025
3ab0425
Apply change to large, bleed breakouts
awesomephant Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions components/src/Breakout/Breakout.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

<Story name="Default" asChild>
<DevContainer
paragraphsAbove={1}
paragraphsBelow={1}
title="Autokauf-Dilemma: Elektroautos teuer, Verbrenner bald auch"
showPlayer={false}
showGrid
Expand Down
11 changes: 0 additions & 11 deletions components/src/Breakout/Breakout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@
width: calc(var(--column-width) * 10 + var(--column-gap) * 9);
margin-left: calc((var(--column-width) * -1) + (var(--column-gap)) * -1);
}
@media (min-width: 1440px) {
width: calc(var(--column-width) * 8 + var(--column-gap) * 7);
margin-left: calc((var(--column-width) * -1) + (var(--column-gap)) * -1);
}
}
.large {
@media (min-width: 640px) {
Expand All @@ -54,10 +50,6 @@
width: calc(var(--column-width) * 12 + var(--column-gap) * 11);
margin-left: calc((var(--column-width) * -2 + var(--column-gap) * -2));
}
@media (min-width: 1440px) {
width: calc(var(--column-width) * 10 + var(--column-gap) * 11);
margin-left: calc((var(--column-width) * -2 + var(--column-gap) * -3));
}
}
.bleed {
width: 100vw;
Expand All @@ -72,8 +64,5 @@
@media (min-width: 1024px) {
margin-left: calc(var(--column-width) * -2 + (var(--column-gap)) * -2 - var(--margin) * 1);
}
@media (min-width: 1440px) {
margin-left: calc(var(--column-width) * -3 + (var(--column-gap)) * -3 - var(--margin) * 1);
}
}
</style>
2 changes: 1 addition & 1 deletion components/src/DevContainer/DevContainer.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
</script>

<Story name="Default" asChild>
<DevContainer theme="light" paragraphsAbove={2} paragraphsBelow={2}>
<DevContainer theme="light" paragraphsAbove={2} paragraphsBelow={2} showGrid>
<DesignTokens>
<div class="chart">your chart here</div>
</DesignTokens>
Expand Down
9 changes: 0 additions & 9 deletions components/src/DevContainer/DevContainer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,6 @@
@media (min-width: 1024px) {
grid-column: 3 / 11;
}
@media (min-width: 1440px) {
grid-column: 4/10;
}
}
.article-header {
margin-bottom: 24px;
Expand All @@ -302,9 +299,6 @@
@media (min-width: 1024px) {
grid-column: 3 / 11;
}
@media (min-width: 1440px) {
grid-column: 4 / 10;
}
}
.article-eyebrow {
font-size: 0.875rem;
Expand Down Expand Up @@ -400,8 +394,5 @@
@media (min-width: 1024px) {
grid-column: 3 / 11;
}
@media (min-width: 1440px) {
grid-column: 4/10;
}
}
</style>