IFDM-92: Initital commit for Mortgage Calculator

[jenbreese]

READY FOR REVIEW

• Can you take a look at this for the math part?

Summary

• New mortgage analysis calculator.

Review By (Date)

• When does this need to be reviewed by?

Criticality

• How critical is this PR on a 1-10 scale? See Severity Assessment.
• E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Check that the design matches up with the code
3. Check the match
4. Review the code.

Front End Validation

• Is the markup using the appropriate semantic tags and passes HTML validation?
• Cross-browser testing has been performed?
• Automated accessibility scans performed?
• Manual accessibility tests performed?
• Design is approved by @ user?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- IFDM-92

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[rebeccahongsf]

I did notice this minor spacing difference where the padding is causing the "Current Loan Term" to appear indented whereas the designs show it aligned with the "Refinance Analysis".

Screenshot of local dev site:

Design:

Otherwise, everything looks great and the math is mathing! Preapproving.

[rebeccahongsf]

Thank you for fixing up the padding, @jenbreese! The reset button looks good.

I did notice this time around that the buttons don’t have a hover or focus state 🤔 Might be something to check in with the client about?

Pre-approving again 👍