Skip to content

Conversation

@sssd-bot
Copy link

This is an automatic backport of PR#8225 adding subid test to branch sssd-2-9-4, created by @danlavu.

Caution

@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8225-to-sssd-2-9-4
git checkout SSSD-sssd-backport-pr8225-to-sssd-2-9-4
git push sssd-bot SSSD-sssd-backport-pr8225-to-sssd-2-9-4 --force

Original commits
449913a - adding subid test

Backported commits

  • 578e073 - CONFLICT! adding subid test

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! adding subid test
On branch SSSD-sssd-backport-pr8225-to-sssd-2-9-4
You are currently cherry-picking commit 449913a8a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   src/tests/system/tests/test_ipa.py

no changes added to commit (use "git add" and/or "git commit -a")

Original Pull Request Body

(cherry picked from commit 449913a)
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request backports a new test file, src/tests/system/tests/test_ipa.py, which includes a suite of integration tests for IPA, including the subid test mentioned in the title. While the additions are valuable, I've identified several areas for improvement to enhance the reliability and maintainability of these new tests. My review includes feedback on hardcoded values, the use of fixed-time sleeps that can lead to flaky tests, and instances of incorrect or incomplete test logic. Addressing these points will strengthen the test suite.

Comment on lines +573 to +575
result = ipa.user("user-1").iduseroverride().show_override("testview1")

assert certificate_content in result.get("usercertificate", [""])[0], "Certificate content mismatch!"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This test aims to verify an ID view override for a user certificate. However, it checks the configuration on the IPA server using ipa.user(...).show_override(...) rather than verifying the outcome on the SSSD client. To properly validate that SSSD has fetched and applied the override, the test should use a client-side tool to inspect the user's certificate as seen by the client.

@danlavu
Copy link

danlavu commented Dec 10, 2025

@alexey-tikhonov Did you want this subid test ported to 2-9-4?

@alexey-tikhonov
Copy link
Member

@alexey-tikhonov Did you want this subid test ported to 2-9-4?

Up to you. Functionally feature should work in this branch.

@danlavu
Copy link

danlavu commented Jan 6, 2026

As we discussed, I'm dropping this PR.

@danlavu danlavu closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants