-
Notifications
You must be signed in to change notification settings - Fork 270
[autobackport: sssd-2-9-4] adding subid test #8295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[autobackport: sssd-2-9-4] adding subid test #8295
Conversation
(cherry picked from commit 449913a)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request backports a new test file, src/tests/system/tests/test_ipa.py, which includes a suite of integration tests for IPA, including the subid test mentioned in the title. While the additions are valuable, I've identified several areas for improvement to enhance the reliability and maintainability of these new tests. My review includes feedback on hardcoded values, the use of fixed-time sleeps that can lead to flaky tests, and instances of incorrect or incomplete test logic. Addressing these points will strengthen the test suite.
| result = ipa.user("user-1").iduseroverride().show_override("testview1") | ||
|
|
||
| assert certificate_content in result.get("usercertificate", [""])[0], "Certificate content mismatch!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test aims to verify an ID view override for a user certificate. However, it checks the configuration on the IPA server using ipa.user(...).show_override(...) rather than verifying the outcome on the SSSD client. To properly validate that SSSD has fetched and applied the override, the test should use a client-side tool to inspect the user's certificate as seen by the client.
|
@alexey-tikhonov Did you want this subid test ported to 2-9-4? |
Up to you. Functionally feature should work in this branch. |
|
As we discussed, I'm dropping this PR. |
This is an automatic backport of PR#8225 adding subid test to branch sssd-2-9-4, created by @danlavu.
Caution
@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
449913a - adding subid test
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body