Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
=======================================
Coverage 87.54% 87.54%
=======================================
Files 77 77
Lines 3694 3694
=======================================
Hits 3234 3234
Misses 460 460 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
p-j-smith
left a comment
There was a problem hiding this comment.
Looks good, a couple of questions:
- the three configs look the same to me (except for the name), just wondering why there can't be a single config / project?
- unrelated to the PR, but as the number of configs grows, should we make sub-directories for them (e.g.
configs/test,configs/education, configs/production`)?
Yeah they've got separate TRE workspaces, which is frustrating
Not a bad shout, I think for that we'd need to double check that we're still checking all configurations and have a different method for defining which subdirectory to look in. What might be an idea is to just move "done" projects to an archive subdirectory? |
Ah I hadn't thought of that. We could do |
And also quote token so whitespace is clear