Skip to content

Added ENV to .env.sample#614

Open
MichaelMallaburn wants to merge 5 commits intoSAFEHR-data:mainfrom
MichaelMallaburn:613-env-in-env-sample
Open

Added ENV to .env.sample#614
MichaelMallaburn wants to merge 5 commits intoSAFEHR-data:mainfrom
MichaelMallaburn:613-env-in-env-sample

Conversation

@MichaelMallaburn
Copy link

@MichaelMallaburn MichaelMallaburn commented Nov 12, 2025

Description

Fixes #613: Adds the ENV environment variable to .env.sample

Type of change

Please delete options accordingly to the description.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Suggested Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have passed on my local host device. (see further details at the CONTRIBUTING document)
  • Make sure your branch is up-to-date with main branch. See CONTRIBUTING for a general example to syncronise your branch with the main branch.
  • I have requested review to this PR.
  • I have addressed and marked as resolved all the review comments in my PR.
  • Finally, I have selected squash and merge

@milanmlft milanmlft changed the title Added ENV to .env.sample. #613 Added ENV to .env.sample Dec 23, 2025
Copy link
Member

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Though I wouldn't set it to prod by default 🙂

@milanmlft milanmlft force-pushed the 613-env-in-env-sample branch from 421c6a9 to 1c03eca Compare December 23, 2025 12:54
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.38%. Comparing base (8ca52a9) to head (ad55580).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   87.89%   85.38%   -2.52%     
==========================================
  Files          76       73       -3     
  Lines        3619     3380     -239     
==========================================
- Hits         3181     2886     -295     
- Misses        438      494      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefpiatek
Copy link
Contributor

Interesting, I wonder if this is being caused by the PR being from a fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing env var ENV in .env.sample

3 participants